Update local type generation scripts #2968
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pLabarta
added
B0-silent
WASM runtime size check:Compared to target branchMoonbase runtime: 2276 KB (no changes) ✅ Moonbeam runtime: 2252 KB (no changes) ✅ Moonriver runtime: 2248 KB (no changes) ✅ Compared to latest release (runtime-3200)Moonbase runtime: 2276 KB (+316 KB compared to latest release) Moonbeam runtime: 2252 KB (+328 KB compared to latest release) Moonriver runtime: 2248 KB (+324 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master pablo/ts-api-overhaul +/- ##
=========================================================
+ Coverage 79.12% 79.13% +0.01%
Files 303 303
+ Lines 88015 88050 +35
=========================================================
+ Hits 69637 69675 +38
- Misses 18378 18375 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Bump
@polkadot/apiversions and update scripts for updating the TypeScript Api from a local build. Also modified/testto use the local package instead of the published one using pnpm workspaces.Usage:
There were some changes to tests to fix errors that appeared when upgrading deps.
What important points reviewers should know?
Is there something left for follow-up PRs?
Yes, following PRs should address:
Using new scripts for updating types in CI
Import types from
moonbeam-types-bundleReview and update types in the bundle
Automate type generation for PRs
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?